Make WalletConnectURI public
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add code sample for better understanding this issue: public enum WCVersionedSession: Equatable {
case v1(WCSession)
case v2(WalletConnectURI)
public static func from(string: String) -> WCVersionedSession? {
if let session = WCSession.from(string: string) {
return .v1(session)
} else if let uri = WalletConnectURI(string: string) {
return .v2(uri)
}
return nil
}
} |
|
@MisterVants @llbartekll please check the sample code above |
llbartekll
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass around
WalletConnectURIbefore paring and typed uri is always safer thanstring, also it might better to have apublic func pair(uri: WalletConnectURI)method inWalletConnectClient